Skip promoting new stable if current stable is not machine=True
#6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "stable" is managed by the user (because they have a `origin/stable` branch, for example) we do not need to calculate which would be the version to be promoted as stable. So, we return immediately (without doing any computation) if the current stable is not managed by Read the Docs.
ericholscher
approved these changes
Feb 24, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
humitos
added
Accepted
|
This is valid. I just need to write some tests for it. |
|
@humitos would be useful to get the tests fixed up here, so we can ship it 👍 |
…humitos/skip-stable-if-not-machine
…humitos/skip-stable-if-not-machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "stable" is managed by the user (because they have a
origin/stablebranch, for example) we do not need to calculate whichwould be the version to be promoted as stable.
So, we return immediately (without doing any computation) if the
current stable is not managed by Read the Docs.